GatewayApiMatcherManager BUG #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=2436 |
sczyh30
reviewed
Nov 3, 2021
| public final class GatewayApiMatcherManager { | ||
|
|
||
| private static final Map<String, WebExchangeApiMatcher> API_MATCHER_MAP = new ConcurrentHashMap<>(); | ||
| private static Map<String, WebExchangeApiMatcher> API_MATCHER_MAP = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Maybe just volatile HashMap is enough?
There was a problem hiding this comment.
使用volatile 会更好吗？
你这是出于什么考虑，而建议使用它呢？
There was a problem hiding this comment.
ConcurrentHashMap -> volatile HashMap
添加 volatile 修饰
This was
linked to
issues
Nov 29, 2021
sczyh30
pushed a commit
that referenced
this pull request
Nov 29, 2021
…re not removed (#2436) * Fix the bug that legacy API matchers in SC gateway adapter GatewayApiMatcherManager were not removed after the API group has been removed
|
Thanks for contributing! |
Zhang-0952
pushed a commit
to Zhang-0952/Sentinel
that referenced
this pull request
Mar 4, 2022
…re not removed (alibaba#2436) * Fix the bug that legacy API matchers in SC gateway adapter GatewayApiMatcherManager were not removed after the API group has been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
网关流控API
当我添加一个API 定义之后，会同时更新GatewayApiMatcherManager
但是当我再将这个API 定义删除之后，也会更新GatewayApiMatcherManager，不过它只会添加不会删除。
Does this pull request fix one issue?
#2433
Describe how you did it
Describe how to verify it
Special notes for reviews