Add data-source extension for OpenSergo fault-tolerance spec #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Zhao <[email protected]>
...ce-opensergo/src/main/java/com/alibaba/csp/sentinel/datasource/OpenSergoDataSourceGroup.java
Show resolved
Hide resolved
| } | ||
|
|
||
| public void start() throws Exception { | ||
| if (started.compareAndSet(false, true)) { |
There was a problem hiding this comment.
Is it possible to set a delayed start here, such as the following code segment:
ScheduledExecutorService singlonThread = Executors
.newSingleThreadScheduledExecutor();
while (!singlonThread.awaitTermination(3000,
TimeUnit.MILLISECONDS)) {
singleThread.shutdown();
}
This is done so that the user can manually set the timeout
Signed-off-by: Eric Zhao <[email protected]>
80639d1 to
e551cbf
Compare
LearningGp
approved these changes
Nov 8, 2022
This was referenced Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao [email protected]
Describe what this PR does / why we need it
Add data-source extension for OpenSergo fault-tolerance specification, so that users could leverage unified OpenSergo CRDs to manage Sentinel rules.
Does this pull request fix one issue?
Resolves #2841
Describe how you did it
Basic design:
OpenSergoRuleAggregator: gather all OpenSergo fault-tolerance rules and convert them to Sentinel rulesCurrent supported strategies:
Describe how to verify it
A demo for creating and registering OpenSergo data-source:
Unit test TBD...
Special notes for reviews
This PR uses a beta version of
opensergo-java-sdk. See https://github.com/opensergo/opensergo-java-sdk for details.