-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: improve lowcode component error state in simulator renderer #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ChatGPT Code Review: CodeReview:
修改建议:
生成的合适的 commit message:feat: add faultComponentMap and modify thisRequiredInJSE in Renderer. |
|
组件设计态报错做了更友好展示。 目前差一个点没有完成,即不知道如何判断运行在 ReactSimulatorRenderer 还是 ReactRenderer |
| import './component.css'; | ||
|
|
||
| export default function componentRendererFactory(): IBaseRenderComponent { | ||
| const { PureComponent, createElement } = adapter.getRuntime(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowcodeFaultComponent 这个配置,是定制 ComponentRender 的 FaultComponent 吗~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前 faultComponent 的问题是,虽然可以替换默认的,但是会把包括 Page/Component/Block 等一些列的都替换掉。那我们是直接增加不同类型的 faultComponent,如增加 componentFaultComponent 还是说,把这个 faultComponent 本身能力增强,可以配置多个。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以把本身能力增强,可以配置多个。包括:低代码组件、区块等等。
No description provided.