Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner March 31, 2023 10:03
@liujuping liujuping force-pushed the feat/fix-autorun-params branch from 7a625ad to 4575f6c Compare April 3, 2023 03:31
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

ChatGPT Code Review:

CodeReview:

  1. utils.ts 中的 getHotterFromSetter 方法,方法名可以更加明确一些,建议改成 getHotkeysFromSetter

  2. utils.ts 中的 Transducer 类,构造函数的参数 context 类型可以更加精准,建议改成 ISettingField

  3. node.ts 中的 Node 类,构造函数中的 ShellProp.create 可能会返回 undefined,建议做一下判断。

  4. node.test.ts 中新增了全局变量的注入,建议在 afterAll 中对其清理。

  5. builtin-hotkey.ts 中的 getSuitablePlaceForNode 方法,可以将 document.checkNesting 的逻辑提取出来,作为一个单独的方法。

  6. metadata.ts 中的 IPublicTypeAutorunItem,参数名应更具意义,建议将 prop 改成 settingField

Commit Message:fix(designer): change autorun params to IPublicModelSettingField

修改了 designer 中的代码,将 Node 类中的 autorun 方法的参数类型改为了 IPublicModelSettingField,修复了因为类型不准确导致的错误。

@JackLian JackLian merged commit 4f7a0b9 into develop Apr 3, 2023
@JackLian JackLian deleted the feat/fix-autorun-params branch April 3, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants