[ISSUE#12979] Develop a maintainer sdk. #13064
Conversation
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
console/pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>com.alibaba.nacos</groupId> | ||
| <artifactId>maintainer-client</artifactId> |
There was a problem hiding this comment.
should be nacos-maintainer-client?
console/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.alibaba.nacos</groupId> | ||
| <artifactId>maintainer-client</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
version follow parent
|
|
||
| @Configuration | ||
| @ConditionalOnProperty(value = Constants.NACOS_DEPLOYMENT_TYPE, havingValue = Constants.NACOS_DEPLOYMENT_TYPE_CONSOLE) | ||
| public class NacosRemoteHandlerConfiguration { |
There was a problem hiding this comment.
Console相关的改动可以放在之后的PR里，先添加maintainer client，可以按照console 所需要的API先行添加。然后再补充一些基础的
| * this is only use in nacos, Custom request type, essentially a GET request, Mainly used for GET request parameters | ||
| * are relatively large,can not be placed on the URL, so it needs to be placed in the body. | ||
| */ | ||
| public static final String GET_LARGE = "GET-LARGE"; |
There was a problem hiding this comment.
maintainer sdk目前没有用到这个
| * @author nkorange | ||
| * @since 0.8.0 | ||
| */ | ||
| public class HttpMethod { |
There was a problem hiding this comment.
这个基础类是从nacos-client copy出来的吗？
There was a problem hiding this comment.
这是common模块copy出来的，现在已经改成依赖common模块了
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
it closes #12979
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.