Improve Error Handling #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
suggested changes
Sep 2, 2025
| /// The actual size of the RLP node in bytes | ||
| size: usize, | ||
| /// The maximum allowed size in bytes | ||
| max: usize, |
There was a problem hiding this comment.
this field seems redundant since max will always be 33, no?
Comment on lines
+44
to
+47
| ProofVerification( | ||
| /// The reason for verification failure | ||
| String | ||
| ), |
There was a problem hiding this comment.
Suggested change
| ProofVerification( | |
| /// The reason for verification failure | |
| String | |
| ), | |
| ProofVerification(#[from] ProofVerificationError), |
seems like you missed to replace this
Comment on lines
+51
to
+56
| HashMismatch { | ||
| /// The expected hash value | ||
| expected: String, | ||
| /// The actual hash value found | ||
| found: String, | ||
| }, |
Comment on lines
+7
to
+12
| /// Error during RLP encoding/decoding | ||
| #[error("RLP error: {0}")] | ||
| RlpError( | ||
| /// The underlying RLP error | ||
| #[from] alloy_rlp::Error | ||
| ), |
There was a problem hiding this comment.
hints at flawed design if we need to have this variant converting alloy_rlp::Error to TrieError as well as the reverse conversion bellow TrieError to alloy_rlp::Error. seems like this variant should be removed.
Comment on lines
+66
to
+69
| stack.push(RlpNode::from_raw_rlp(&bytes[..len]).map_err(|e| match e { | ||
| TrieError::RlpNodeTooLarge { .. } => alloy_rlp::Error::Custom("RLP node too large"), | ||
| _ => alloy_rlp::Error::Custom("unexpected error decoding RLP node"), | ||
| })?); |
There was a problem hiding this comment.
seems like this change can be reverted since the conversion From<TrieError> for alloy_rlp::Error was implemented
Comment on lines
+17
to
+22
| Self::from_raw_rlp(bytes).map_err(|e| match e { | ||
| TrieError::RlpNodeTooLarge { size: _, max: _ } => { | ||
| alloy_rlp::Error::Custom("RLP node too large") | ||
| } | ||
| _ => alloy_rlp::Error::Custom("unexpected error decoding RLP node"), | ||
| }) |
Comment on lines
+68
to
+72
| pub fn from_raw_rlp(data: &[u8]) -> Result<Self, TrieError> { | ||
| Self::from_raw(data).ok_or_else(|| TrieError::RlpNodeTooLarge { | ||
| size: data.len(), | ||
| max: MAX, | ||
| }) |
There was a problem hiding this comment.
makes more sense if this returns alloy_rlp::Result<Self> still and just do TrieError::RlpNodeTooLarge.into()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the error handling by using
thiserrorforcore::error::Errorimplementations.Fixes #90