Replace multiple binds #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6836904 to
821eee3
Compare
adrianmroz
reviewed
Oct 24, 2018
| private onScroll = (e: React.UIEvent<HTMLElement>) => { | ||
| const { bodyWidth, bodyHeight } = this.props.layout; | ||
| const { viewportWidth, viewportHeight } = this.state; | ||
| var target = e.target as Element; |
There was a problem hiding this comment.
Do we need as Element here if we narrowed type of event?
There was a problem hiding this comment.
From what I recall e.target was instance of EventTarget, which resulted in errors.
The main purpose of this PR is to get rid of using bind so I did not want to spend more time on fixing this (as this is my first experience with Typescript :) ).
There was a problem hiding this comment.
Sure thing! I'm just writing it down to look into later.
adrianmroz
reviewed
Oct 25, 2018
| } | ||
|
|
||
| export class ClearableInput extends React.Component<ClearableInputProps, ClearableInputState> { | ||
| static defaultProps = { |
adrianmroz
reviewed
Oct 25, 2018
| timeString: "" | ||
| }; | ||
| } | ||
| state = { |
There was a problem hiding this comment.
Missing type of state. Typescript does not always infer type of state field. I wonder why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #203.
It took me some time but I eventually managed to replaced all instances of
.bind(this)with class property bindings. Additionally I replaced unnecessary constructors in few places with setting state via class property.This change should not break anything, but I had a lot of conflicts to resolve due to today's merges so please review carefully.