Remove colorBounds metadata property #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2022 11:39
|
Great find, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
renderInstanceSegmentationflag, we generate acolorBoundsproperty which is used to populate theinstance_detections2Dfield in the event (Python side). The current way this is done is extremely inefficient since we effectively grab the data twice for the segmented image. We then iterate pixel by pixel to determine the bounds. This is has been moved to the Python side and is done using numpy. I observed a performance improvement of ~60%. If for some reasoncolorBoundsis being used on the Python side by an end user or for some reason we decide we need it, we can populate the metadata directly from the python side with the bounding boxes and corresponding colors.