Add support for editing the number of replicas. #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new property to the `skiff.json` file that makes it easy to manage the number of replicas. I also wrote some docs for how things work. I imagine we'll need to add GPU support too at some point. @soldni just send me a note when you're ready to do so, and I can help with that too.
soldni
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new property to the
skiff.jsonfile that makes iteasy to manage the number of replicas.
I also wrote some docs for how things work.
I imagine we'll need to add GPU support too at some point. @soldni
just send me a note when you're ready to do so, and I can help
with that too.
https://github.com/allenai/skiff/issues/1465