Fix DUE checking in recurrent todo #537
Open
+2
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also found that even tho DTSTART is required with RRULE, it's only checked in |
62ab4a8 to
6622a40
Compare
allenporter
reviewed
Oct 29, 2025
| } | ||
| ), | ||
| ( | ||
| { |
There was a problem hiding this comment.
Can we add tests for how these cases do behave w.r.t. recurring TODO? You mentioned duration having an effect here, though not sure that happens as of this PR yet. Any other tests for duration that need to be added or is existing coverage good?
Thank you for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo.as_rrule()Since DUE is exclusive with DURATION, by making DUE optional, this...
Fixes #534