Change nreverse to non-destructive version#137
Closed
natrys wants to merge 1 commit intoalphapapa:masterfrom
Closed
Change nreverse to non-destructive version#137natrys wants to merge 1 commit intoalphapapa:masterfrom
natrys wants to merge 1 commit intoalphapapa:masterfrom
Conversation
Owner
|
Thanks, this is probably the right way to fix it. I'll look at it and merge when I have time. |
e441d88 to
4194456
Compare
f52bef0 to
ec0f8c7
Compare
Owner
|
Fixed in 29090c4 and 0.4.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fixes #136 . I believe the issue stemmed from the fact that elisp lists are passed by reference, not value, so a destructive operation on a function parameter here changed the original list passed to
org-ql-searchup the stack.If
nreversewas desired behaviour here, I can try some other way of fixing the linked issue.