fix: make GetRawRoot() work properly with GitHub #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc @sebbalex (test are failing for an unrelated issue even if the same code passed before https://github.com/alranel/go-vcsurl/actions, |
This was referenced Mar 11, 2022
GetRawRoot() failed to return the correct root when passed GitHub URLs ending with .git (eg. https://github.com/foo/bar.git), which are supposed to be equivalent to the same URL without ".git". That was disguised by the fact that GetRepo() erroneously stripped the ".git" suffix from the passed URL and made it work when called before GetRawRoot() with the same argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRawRoot() failed to return the correct root when passed GitHub
URLs ending with .git (eg. https://github.com/foo/bar.git), which
are supposed to be equivalent to the same URL without ".git".
That was disguised by the fact that GetRepo() erroneously stripped
the ".git" suffix from the passed URL and made it work when called
before GetRawRoot() with the same argument.