-
Notifications
You must be signed in to change notification settings - Fork 13
egglog-like e-graph visualisation as Graphviz Dot file #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alt-romes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @ren-zeng. Just a few notes about conditional compilation for the test but is ready otherwise.
|
Could I ask you to rebase this PR on master please? I've pushed d177304 which should make CI run on your pull request. Thanks! |
|
Thanks for your work here. It is much appreciated. Since CI is Green now, I'll go ahead and merge it. Feel free to open more tickets if you find issues with the library or if you have any question regarding its usability. |
|
Thank you for guiding me through the process and everyone involved in this cool library :) |
This pull request address #26 by providing functionality to visualise e-graph using a consistent style with egglog. The main modified file is
Dot.hs, which contains detailed haddock documentation.Main usage:
toDotFile'allow user to customise how analysis and e-nodes are displayed asTexttoDotFileis a special default case fortoDotFile'based on theShowinstancesNotes for reviewer (@alt-romes):
SimpleSymtest case at the root. Feel free to exclude or modify how this test should be integrated.