Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@xbwwj
Copy link
Contributor

@xbwwj xbwwj commented Dec 15, 2024

Fix #290

This PR disables raw mode temporarily in interactive git command, which will fix the staircase git output caused by LF-CRLF conversion in raw mode.

@altsem
Copy link
Owner

altsem commented Dec 15, 2024

Nice catch! I've been bothered by this myself. :)

Just two things I think:

  • The commit title goes straight to the changelog. So it should be on a bit higher level. Something like "fix: staircased git output" perhaps?

  • You could probably put enable/disable raw mode in the "Term" struct. term.enable_raw_mode()?; to fix the tests.

@xbwwj
Copy link
Contributor Author

xbwwj commented Dec 15, 2024

Just updated the commit.

I have succeeded in running cargo test and cargo insta test. But make test still complains about other parts of the code.

Copy link
Owner

@altsem altsem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work in CI! I'll merge this. Gj!

edit: oh the Linux CI fails whereas windows/mac succeed.
Looks like the linter had some rules added. It's a master-problem anyway.

@altsem altsem merged commit 30cb217 into altsem:master Dec 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong output indentation

2 participants