Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use Stdio::inherit() in run_cmd_interactive (likely fix for #215) #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the-kenny wants to merge 2 commits into from
Closed

Use Stdio::inherit() in run_cmd_interactive (likely fix for #215) #301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d64a413
Use `Stdio::inherit()` when spawning `git commit` and similar.
the-kenny Jan 5, 2025
9f2d9ab
run_cmd_interactive: Capture `stderr` to show its output
the-kenny Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,20 @@ impl State {

cmd.current_dir(self.repo.workdir().expect("No workdir"));

cmd.stdin(Stdio::piped());
// Previously `Stdio::pipe()` was used here, likely causing
// https://github.com/altsem/gitu/issues/215 and similar issues.
cmd.stdin(Stdio::inherit());
// Redirect stderr so we can capture it via `Child::wait_with_output()`
cmd.stderr(Stdio::piped());

// git will have staircased output in raw mode (issue #290)
// disable raw mode temporarily for the git command
term.backend().disable_raw_mode()?;

// If we don't show the cursor prior spawning (thus restore the default
// state), the cursor may be missing in $EDITOR.
term.show_cursor()?;

let child = cmd.spawn()?;

let out = child.wait_with_output()?;
Expand Down
Loading