refactor: more efficient/sane diff repr #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01c50f8 to
744f60b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #323 +/- ##
==========================================
- Coverage 87.71% 87.57% -0.15%
==========================================
Files 63 65 +2
Lines 5627 5965 +338
==========================================
+ Hits 4936 5224 +288
- Misses 691 741 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This aims to start the over-haul of the diffing/highlighting/patch-generation of Gitu. - Remove hard dependency of Ratatui in this layer. - Reduce cloning/joining strings together, might mess something up. - Simplify inline-diffing (use the original line-diff output instead of redundantly diffing files again). - Simplify merging of styles. Also, Gitu being able to parse diffs/patches opens up possibilities for some better CLI use-cases: ```sh git diff | gitu ```
apparently git scans for zeroes in the first few bytes of the file
8fefa1b to
e49a37d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to start the over-haul of the
diffing/highlighting/patch-generation of Gitu.
Also, Gitu being able to parse diffs/patches
opens up possibilities for some better CLI use-cases:
git diff | gitu