Fix a process bug when running show commands on Windows #330
Conversation
|
Note that there are some tests that this currently breaks, so I'll fix these before calling it ready to merge. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 87.71% 87.73% +0.01%
==========================================
Files 63 63
Lines 5627 5636 +9
==========================================
+ Hits 4936 4945 +9
Misses 691 691 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Fixes a Windows-specific bug where subprocess commands for showing and editing operations fail because they need to be executed through cmd /C on Windows systems.
- Adds Windows-specific command execution logic using
cmd /Cprefix - Maintains existing Unix/Linux behavior with conditional compilation
- Ensures editor commands work correctly across all platforms
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
edit: code seems fine, I'll merge this and just change the commit title to generate a changelog. |
With the released version, all gitu commands for showing, editing etc. using the
EDITORenv var and others will fail because we try to launch the subprocess command directly.On Windows, this doesn't work; Commands need to be prepended with
cmd /Cto be executed in sub-shells.