feat: Fall back to remote.pushDefault when branch pushRemote is not set #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 86.60% 86.64% +0.04%
==========================================
Files 66 66
Lines 6100 6126 +26
==========================================
+ Hits 5283 5308 +25
- Misses 817 818 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
altsem
approved these changes
Apr 17, 2025
Owner
altsem
left a comment
There was a problem hiding this comment.
Looks good! tests, and nice commit message. I'll just merge it.
This was referenced Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where
get_push_remotewould have returnedOk(None)now first tryget_default_push_remotewhich will consult theremote.pushDefaultgit config option, before either returning the fallback push remote, or no result.Fixes #346