refactor: add new state.prompt() function and simplify event handling #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 87.50% 88.47% +0.97%
==========================================
Files 66 66
Lines 6537 6585 +48
==========================================
+ Hits 5720 5826 +106
+ Misses 817 759 -58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This refactor introduces a new synchronous state.prompt() function and simplifies event handling throughout the codebase. Key changes include replacing callback‐based prompt logic with a synchronous prompt call, refactoring event handling to remove the GituEvent abstraction, and updating multiple ops to use the new prompt and confirmation APIs.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/tests/commit.rs | Updates function calls to use the new update API |
| src/term.rs | Adjusts the Test backend structure and adds poll_event/read_event methods |
| src/state.rs | Refactors event loop and prompt handling, adds new functions (prompt, confirm, etc.) |
| src/prompt.rs | Removes the outdated on_success callback from PromptData |
| src/ops/* | Updates prompt usage across various git operations |
| src/lib.rs | Removes unused GituEvent and simplifies run logic |
Comments suppressed due to low confidence (1)
src/term.rs:171
- Consider returning Ok(false) instead of an error when no events are available in the Test backend. This would align its behavior with the Crossterm branch and simplify handling in test scenarios.
TermBackend::Test { events, .. } => { if events.is_empty() { Err(Error::NoMoreEvents) } else { Ok(true) } },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aims to enable: #350, and simplify the already existing use-cases.
TODO: