feat: add delete option to branch menu #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilwaz
commented
May 14, 2025
altsem
requested changes
May 20, 2025
Owner
altsem
left a comment
There was a problem hiding this comment.
feat: add delete branch goes straight to the changelog (we've got changelog generation set up).
So perhaps something just a little more descriptive to the users would be nice.
There is actually another place where this same "prompt y or n to delete branch" should be happening, and that is in the "discard" action. Not a requirement for this PR, include it if you wish, else we'll fix it later.
relates to: #350
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 88.21% 88.28% +0.06%
==========================================
Files 66 67 +1
Lines 6668 6750 +82
==========================================
+ Hits 5882 5959 +77
- Misses 786 791 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
altsem
reviewed
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for deleting branches from the branch menu. If a branch hasn't been merged into upstream or HEAD, the operation must be confirmed (similar to how to
git branch -d ...works).