feat: ability to delete a remote #390
Conversation
src/default_config.toml
Outdated
|
|
||
| root.remote_menu=["M"] | ||
| remote_menu.add_remote=["a"] | ||
| remote_menu.remove_remote=["k"] |
There was a problem hiding this comment.
We bound the new "delete branch" to "K" to be consistent with discarding stuff I believe.
I think this should have the same binding, it'd be nice for it to be consistent across the board.
There was a problem hiding this comment.
That's been changed
|
Hi! This seems like a nice addition, I left some comments. See if they make sense :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 85.66% 87.06% +1.39%
==========================================
Files 68 68
Lines 7282 7204 -78
==========================================
+ Hits 6238 6272 +34
+ Misses 1044 932 -112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To be consistent with other prompts relating to discarding/deleting things.
| ? Rename to: › | | ||
| styles_hash: 2723afb20d7e3ef0 |
There was a problem hiding this comment.
I think the test just needs updating, it must be seeing M, skipping k, skipping o and then picking up r as in "rename".
|
I rebased, fixed the test and merged this to master! |
Oh I just sat down to do this. Thanks! |
Adds the ability to remove a remote. Used
kas that is what magit uses.