fix: Ignore mouse clicks in empty regions #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pressing a mouse button on an invalid line the effect is the same as having clicked on the currently selected line. This is a bit of a jarring experience because it will often perform an unexpected action. Invalid screens lines include: - Lines that are unselectable - Empty lines - Lines beyond the bounds of the screen
altsem
approved these changes
Sep 28, 2025
Owner
altsem
left a comment
There was a problem hiding this comment.
Nice! I'll merge it in and make a release 🥳
| ctx.update(&mut app, vec![mouse_event(0, 4, MouseButtons::LEFT)]); | ||
| insta::assert_snapshot!(ctx.redact_buffer()); | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
It might make sense to move these things into src/tests/editor.rs at some point.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 86.50% 86.62% +0.12%
==========================================
Files 71 71
Lines 7319 7385 +66
==========================================
+ Hits 6331 6397 +66
Misses 988 988 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pressing a mouse button on empty lines, or in the empty region at the bottom of the screen, the effect is the same as having clicked on the currently selected line. This is a bit of a jarring experience because it will often perform an unexpected action relative to where the mouse cursor actually is.
This PR changes mouse click events on invalid lines to be ignored, where invalid screens lines are:
I added tests for selecting hunk lines and other things that I found were missing test coverage.