refactor: use nom for status parsing #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the Git status parsing implementation from the pest parser to nom, along with associated test and build configuration updates.
- Replaces pest-based parser with nom combinators for parsing Git status output
- Removes the external
.pestgrammar file in favor of in-code parser functions - Updates snapshot test to reflect "On branch main" instead of "No branch"
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/git/parse/status/mod.rs |
Complete rewrite using nom parser combinators, adds comprehensive test coverage for edge cases |
src/git/parse/status/status.pest |
Removed pest grammar file as it's replaced by nom parser functions |
Cargo.toml |
Removed pest and pest_derive dependencies |
Cargo.lock |
Removed transitive dependencies of pest (sha2, digest, etc.) |
flake.nix |
Simplified build configuration by removing custom pest file filtering |
src/tests/snapshots/gitu__tests__fresh_init.snap |
Updated snapshot to reflect current behavior showing "On branch main" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c7d9e69 to
8995137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.