If no decorator is found, fall back to decorators for parent classes#19
Open
johanlindblad wants to merge 1 commit intoamatsuda:masterfrom
Open
If no decorator is found, fall back to decorators for parent classes#19johanlindblad wants to merge 1 commit intoamatsuda:masterfrom
johanlindblad wants to merge 1 commit intoamatsuda:masterfrom
Conversation
Contributor
|
+1 I want to do the same thing, too. I have other idea that class Parent < ActiveRecord::Base
end
class Child < Parent
decorator ParentDecorator
end
module ParentDecorator
def name
link_to name, parent_path
end
end |
|
any advance on this, how can I decorate a STI models (parent and childs), how is the folder structure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use single table inheritance quite a lot so I made this in order to avoid having to create a decorator for every single child class if all I need is common functionality.
With this change, a class
Childthat inherits fromParentwill be decorated withParentDecoratorif noChildDecoratorexists.I considered making it so that both
ChildDecoratorandParentDecoratorwould be included of both exist but I am not sure if that is a good idea. Now I just includeParentDecoratorin myChildDecoratormanually which works just fine.