Add support for meshes to primitive builders #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 13, 2024 16:34
1. Creation of a meshbuilder on a box 2. Creation of a meshbuilder on a custom mesh
diegoferigo
requested changes
May 14, 2024
diegoferigo
reviewed
May 14, 2024
diegoferigo
reviewed
May 14, 2024
diegoferigo
reviewed
May 14, 2024
diegoferigo
reviewed
May 15, 2024
diegoferigo
approved these changes
May 15, 2024
src/rod/builder/primitives.py
Outdated
Comment on lines
80
to
82
| extension = self.mesh_path.split(".")[-1] | ||
| elif isinstance(self.mesh_path, pathlib.Path): | ||
| extension = self.mesh_path.suffix | ||
| extension = str(self.mesh_path).split(".")[-1] |
There was a problem hiding this comment.
Last curiosity, any specific reason to go back to string?
There was a problem hiding this comment.
It was just not working without a suffix keyword for NamedTempFile. I can easily revert back.
diegoferigo
approved these changes
May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the possibility to build meshes by using trimesh.
It implements a
MeshBuilderclass which implements the calculation for the mesh's moment of inertia and its geometry.Summary of changes:
inertiaandgeometrymethods with a calculation usingtrimeshmethods.