Remove now-unnecessary Makevars with Rcpp::LdFlags#647
Merged
stefvanbuuren merged 1 commit intoamices:masterfrom Jul 29, 2024
Merged
Remove now-unnecessary Makevars with Rcpp::LdFlags#647stefvanbuuren merged 1 commit intoamices:masterfrom
stefvanbuuren merged 1 commit intoamices:masterfrom
Conversation
Rcpp:::LdFlags() is deprecated and produces an empty string (https://www.rdocumentation.org/packages/Rcpp/versions/1.0.12/topics/LdFlags-deprecated), and hasn't been needed for long enough that there may not be loss in compatibility with current systems (RcppCore/Rcpp#1302 (comment)). Removing these Makevars settings is a simple way to address issues for some system x Rprofile combinations (amices#646).
Member
|
I found that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rcpp:::LdFlags() is deprecated and produces an empty string, and hasn't been needed for long enough that there may not be loss in compatibility with current
systems. Removing these Makevars settings is a simple way to address issues for some system x Rprofile combinations that I encountered (#646).
Benefits:
PKG_LIBSsetting via system Makevars / environment variables, that setting will no longer be overwritten, which is presumably desirable.Risks and drawbacks: