Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix UvDriver #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelunik merged 2 commits into from
May 2, 2020
Merged

Fix UvDriver #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86416dc
Fix UvDriver
enumag May 2, 2020
71a762b
Apply suggestions from code review
enumag May 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UvDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function __construct(Loop\UvDriver $driver)
$this->loop = $driver->getHandle();
$this->poll = new Internal\UvPoll;

$this->priorVersion = \version_compare('0.3.0', \phpversion('uv')) < 0;
$this->priorVersion = \version_compare(\phpversion('uv'), '0.3.0', '<');
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/UvFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public function __construct(Loop\UvDriver $driver, Internal\UvPoll $poll, $fh, s

$this->queue = new \SplQueue;

$this->priorVersion = \version_compare('0.3.0', \phpversion('uv')) < 0;
$this->priorVersion = \version_compare(\phpversion('uv'), '0.3.0', '<');
}

public function read(int $length = self::DEFAULT_READ_LENGTH): Promise
Expand Down
14 changes: 14 additions & 0 deletions test/UvDriverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,18 @@ protected function setUp(): void
Loop::set($loop);
File\filesystem(new File\UvDriver($loop));
}

/**
* @dataProvider readlinkPathProvider
*
* @param \Closure $linkResolver
*/
public function testReadlinkError(\Closure $linkResolver): \Generator
{
if (\version_compare(\phpversion('uv'), '0.3.0', '<')) {
$this->markTestSkipped('UvDriver Test Skipped: Causes Crash');
}

yield from parent::testReadlinkError($linkResolver);
}
}