-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add KeyedFileMutex #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace Amp\File; | ||
|
|
||
| use Amp\Sync\KeyedMutex; | ||
| use Amp\Sync\Lock; | ||
| use Amp\Sync\SyncException; | ||
| use ValueError; | ||
| use function Amp\delay; | ||
|
|
||
| final class KeyedFileMutex implements KeyedMutex | ||
| { | ||
| private const LATENCY_TIMEOUT = 0.01; | ||
|
|
||
| private readonly Filesystem $filesystem; | ||
|
|
||
| private readonly string $directory; | ||
|
|
||
| /** | ||
| * @param string $directory Directory in which to store key files. | ||
| */ | ||
| public function __construct(string $directory, ?Filesystem $filesystem = null) | ||
| { | ||
| $this->filesystem = $filesystem ?? filesystem(); | ||
| $this->directory = \rtrim($directory, "/\\"); | ||
|
|
||
| if (!$this->filesystem->isDirectory($this->directory)) { | ||
| throw new ValueError(\sprintf('Directory "%s" does not exist', $this->directory)); | ||
| } | ||
| } | ||
|
|
||
| public function acquire(string $key): Lock | ||
| { | ||
| $filename = $this->getFilename($key); | ||
|
|
||
| // Try to create the lock file. If the file already exists, someone else | ||
| // has the lock, so set an asynchronous timer and try again. | ||
| while (true) { | ||
| try { | ||
| $file = $this->filesystem->openFile($filename, 'x'); | ||
|
|
||
| // Return a lock object that can be used to release the lock on the mutex. | ||
| $lock = new Lock(fn () => $this->release($filename)); | ||
|
|
||
| $file->close(); | ||
|
|
||
| return $lock; | ||
| } catch (FilesystemException) { | ||
| delay(self::LATENCY_TIMEOUT); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Releases the lock on the mutex. | ||
| * | ||
| * @throws SyncException | ||
| */ | ||
| private function release(string $filename): void | ||
| { | ||
| try { | ||
| $this->filesystem->deleteFile($filename); | ||
| } catch (\Throwable $exception) { | ||
| throw new SyncException( | ||
| 'Failed to unlock the mutex file: ' . $filename, | ||
| previous: $exception, | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| private function getFilename(string $key): string | ||
| { | ||
| return $this->directory . '/' . \hash('sha256', $key) . '.lock'; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| <?php declare(strict_types=1); | ||
|
|
||
| namespace Amp\File\Test; | ||
|
|
||
| use Amp\File\KeyedFileMutex; | ||
| use Amp\Sync\AbstractKeyedMutexTest; | ||
| use Amp\Sync\KeyedMutex; | ||
|
|
||
| final class KeyedFileMutexTest extends AbstractKeyedMutexTest | ||
| { | ||
| protected function setUp(): void | ||
| { | ||
| parent::setUp(); | ||
| Fixture::init(); | ||
| } | ||
|
|
||
| protected function tearDown(): void | ||
| { | ||
| parent::tearDown(); | ||
| Fixture::clear(); | ||
| } | ||
|
|
||
| public function createMutex(): KeyedMutex | ||
| { | ||
| return new KeyedFileMutex(Fixture::path()); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For longer held locks, this is very inefficient. Should we backoff exponentially up to 1 second?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a good idea. This is exactly what we're doing for
FileMutexas well, so I'd say let's update both then.