Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't filter out PRs/issues that match the release tag date #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2022
Merged

Don't filter out PRs/issues that match the release tag date #27

merged 1 commit into from
Mar 23, 2022

Conversation

@wagoodman
Copy link
Contributor

There is an edge case where if an issue or PR close timestamp matches the same timestamp as the release the changelog is being generated for, then the PR/issue in question is filtered out:

[0000] DEBUG github owner="wagoodman" repo="chronicle-test" path="../chronicle-test"
[0000]  INFO since tag="v0.0.0" date="2022-03-23 20:24 UTC"
[0000]  INFO until tag="v0.1.0" commit="5d95ff3aba8b6619b59f85f24332bc3ab5b0ae11"
[0000] DEBUG total merged PRs discovered: 2
[0000] TRACE PR #2 filtered out: merged after 2022-03-23 20:19 UTC (merged 2022-03-23 20:19 UTC)
[0000] DEBUG PRs contributing to changelog: 1
[0000] DEBUG total closed issues discovered: 0
[0000] DEBUG issues contributing to changelog: 0
[0000]  INFO discovered changes: 1
[0000] DEBUG   └── added-feature: 1

The correct behavior (which this PR fixes) is to keep the edge PR/issue included in the list of changes:

[0000] DEBUG github owner="wagoodman" repo="chronicle-test" path="../chronicle-test"
[0000]  INFO since tag="v0.0.0" date="2022-03-23 20:24 UTC"
[0000]  INFO until tag="v0.1.0" commit="5d95ff3aba8b6619b59f85f24332bc3ab5b0ae11"
[0000] DEBUG total merged PRs discovered: 2
[0000] DEBUG PRs contributing to changelog: 2
[0000] DEBUG total closed issues discovered: 0
[0000] DEBUG issues contributing to changelog: 0
[0000]  INFO discovered changes: 2
[0000] DEBUG   └── added-feature: 2

@wagoodman wagoodman added the bug Something isn't working label Mar 23, 2022
@wagoodman wagoodman self-assigned this Mar 23, 2022
@wagoodman wagoodman merged commit a9edfe7 into main Mar 23, 2022
@wagoodman wagoodman deleted the keep-dates-equal-to branch March 23, 2022 21:28
@wagoodman wagoodman mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@wagoodman wagoodman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wagoodman