Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add authors for issue entries #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 24, 2023
Merged

feat: add authors for issue entries #41

merged 8 commits into from
Jan 24, 2023

Conversation

@kzantow
Copy link
Contributor

@kzantow kzantow commented Jan 23, 2023 •
edited
Loading

This adds PR authors for issue entries.

The current Grype changelog looks like this:

# Changelog

## [(Unreleased)](https://github.com/anchore/grype/tree/) (2023-01-23)

[Full Changelog](https://github.com/anchore/grype/compare/v0.55.0...)

### Added Features

- Allow db diff to specify local files [[Issue #1059](https://github.com/anchore/grype/issues/1059)] [[kzantow](https://github.com/kzantow)]

### Bug Fixes

- False positive CVE-2015-5237 for protobuf-go [[Issue #558](https://github.com/anchore/grype/issues/558)] [[luhring](https://github.com/luhring)]
- Getting many warnings (empty ID, unable to read golang buildinfo, bin parsing) when running grype from command line and directing stderr to file [[Issue #1050](https://github.com/anchore/grype/issues/1050)]
- Missing severities in embedded-cyclonedx-vex-json format since v0.55.0 [[Issue #1066](https://github.com/anchore/grype/issues/1066)] [[kzantow](https://github.com/kzantow)]

@kzantow kzantow mentioned this pull request Jan 24, 2023
Merged
@kzantow kzantow mentioned this pull request Jan 24, 2023
Merged
@kzantow kzantow changed the title feat: add authors for issue entries, display unlabeled PRs feat: add authors for issue entries Jan 24, 2023
kzantow
kzantow commented Jan 24, 2023
View reviewed changes
internal/git/remote.go
"github.com/anchore/chronicle/internal"
)

var remotePattern = regexp.MustCompile(`(?m)\[remote "origin"](\n.*)*url\s*=\s*(?P<url>.*)$`)
Copy link
Contributor Author

@kzantow kzantow Jan 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sneaking in a fix -- this was reading a url from the vulnerability-match-labels or other remote because it was multiline and had a .* in the middle.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch

@kzantow kzantow marked this pull request as ready for review January 24, 2023 05:51
@kzantow kzantow requested a review from a team January 24, 2023 05:51
@kzantow kzantow mentioned this pull request Jan 24, 2023
Merged
@kzantow kzantow merged commit 4831884 into main Jan 24, 2023
@kzantow kzantow deleted the feat/author-names branch January 24, 2023 14:26
@wagoodman wagoodman added the enhancement New feature or request label Jan 24, 2023
@kzantow kzantow self-assigned this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees

@kzantow kzantow

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kzantow @wagoodman