Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(equality): fall back to reflect.DeepEquals #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix(equality): fall back to reflect.DeepEquals #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tagged_value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,5 @@ func isEqual[T any](a, b T) bool {
if va.Type().Kind() == reflect.Func {
return fmt.Sprintf("%v", a) == fmt.Sprintf("%v", b)
}
return false
return reflect.DeepEqual(a, b)
}
38 changes: 38 additions & 0 deletions tagged_value_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,44 @@ import (
"github.com/stretchr/testify/require"
)

func Test_TaggedInterfaces(t *testing.T) {
type t1 struct {
name string
field []string // not comparable
}

a := []string{"a"}
b := []string{"b"}
c := []string{"c"}
set1 := TaggedValueSet[any]{TaggedValue[any]{Value: t1{name: "a"}, Tags: a}, TaggedValue[any]{Value: t1{name: "b"}, Tags: b}}
set2 := TaggedValueSet[any]{TaggedValue[any]{Value: t1{name: "c"}, Tags: c}}

s := set2.Join(set2...)
require.Len(t, s, 1)

s = set1.Join(set2...)
require.Len(t, s, 3)

s = s.Join(set1...).Join(set2...)
require.Len(t, s, 3)
}

func Test_TaggedFuncs(t *testing.T) {
a := func() {}
b := func() {}
set1 := TaggedValueSet[any]{TaggedValue[any]{Value: a}}
set2 := TaggedValueSet[any]{TaggedValue[any]{Value: b}}

s := set2.Join(set2...)
require.Len(t, s, 1)

s = set1.Join(set2...)
require.Len(t, s, 2)

s = s.Join(set1...).Join(set2...)
require.Len(t, s, 2)
}

func Test_Tagged(t *testing.T) {
set := TaggedValueSet[int]{
NewTaggedValue(1, "one"),
Expand Down