Add option to output vulnerability report to a file #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
luhring
approved these changes
Oct 5, 2021
Comment on lines
+13
to
+28
| path := strings.TrimSpace(appConfig.File) | ||
| switch len(path) { | ||
| case 0: | ||
| return os.Stdout, nop, nil | ||
| default: | ||
| reportFile, err := os.OpenFile(path, os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0644) | ||
| if err != nil { | ||
| return nil, nop, fmt.Errorf("unable to create report file: %w", err) | ||
| } | ||
| return reportFile, func() error { | ||
| if !appConfig.Quiet { | ||
| fmt.Printf("Report written to %q\n", path) | ||
| } | ||
| return reportFile.Close() | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
very small nit: This is a good example of code that's well structured, but could be more readable if vertical spacing were leveraged more. Blank lines to separate subsections of thoughts can be really nice for readers looking to get a sense of structure, particular with regard to control flow — e.g., using blank lines to make return lines more clear.
There was a problem hiding this comment.
I'll add some space to break this up 👍
There was a problem hiding this comment.
anchore/syft#536 and #443
This was referenced Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--fileoption that writes the report bytes out to the given file path consistent with anchore/syft#530 .Closes #207