362 add binary for linux arm64 to release process #465
Conversation
Signed-off-by: Christopher Angelo Phillips <[email protected]>
| - binary: grype | ||
| id: grype-arm64 |
There was a problem hiding this comment.
I think we'd want to make sure we're taking the same codesigning steps for this darwin/arm64 binary that we do today for the darwin/amd64 binary — let me know if you want to chat through this!
There was a problem hiding this comment.
That's my bad @luhring I forgot to update the goos to linux for amd64. I don't think there is any other signing we need to include if this is a linux release.
I added build under archives so zip artifacts are included for this new build ID.
Let me know if you need anything else here.
There was a problem hiding this comment.
Ah gotcha! Good clarification. I think the only "signing" would be that this new binary gets its checksum added to the ...checksums.txt file, and that file itself gets signed. Does that sound right?
There was a problem hiding this comment.
Right now our checksums file output looks like this:
38c9917da5f43702770307095e063749f7d1b92222e840d46973acd029b55c4c grype_0.23.0_linux_amd64.rpm
4e04801f614981b1e7c2d8bb32be53c0e2679bfd7b64a30315515f23133cc9a9 grype_0.23.0_linux_amd64.deb
d277030c12fdfe1a43503c95a34fb1e1556f1dba8d42458abb2b542a201828ba grype_0.23.0_linux_amd64.tar.gz
Adding the block in this PR to the builds section would mean the new build should be appended. Everything but the zip artifact is included here. I don't think there is any other code to change.
- 'sed "/.*\.zip/d" ${artifact} > tmpfile && mv tmpfile ${artifact} && gpg --output ${signature} --detach-sign ${artifact}'
Signed-off-by: spiffcs <[email protected]> Signed-off-by: Christopher Angelo Phillips <[email protected]>
6c4a40f to
61d18ca
Compare
Add arm64 goarch as a release binary.
Resolves #362
Signed-off-by: Christopher Angelo Phillips [email protected]