Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix hang when running as a subprocess #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2021
Merged

Fix hang when running as a subprocess #484

merged 5 commits into from
Oct 29, 2021

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Oct 28, 2021 •
edited
Loading

Today if you run grype as a subprocess you may see it hang forever. This is due to grype waiting for input in stdin in cases when it shouldn't be. This PR makes two changes:

  1. Use the FIFO (named pipe) mode bit to be set on stdin as an indicator of bytes could be expected on stdin (not the absence of a character device)
  2. If the CLI hints at input coming from elsewhere (not stdin) then stdin is ignored

Additional changes were made that were related:

  1. Removes the grype supplied code for unmarshaling Syft JSON. This is now provided by Syft format decode capabilities for all SBOM formats (more formats being implemented soon)
  2. Removes the provider abstraction since Syft will be providing SBOM decoding capabilities, not grype.

This addresses a regression from v0.23.0 to v0.24.0 reported in community slack. Fixes #267 .

@wagoodman wagoodman added the bug Something isn't working label Oct 28, 2021
@wagoodman wagoodman requested a review from a team October 28, 2021 14:57
@wagoodman wagoodman self-assigned this Oct 28, 2021
@wagoodman wagoodman marked this pull request as ready for review October 29, 2021 14:00
luhring
luhring approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

test/cli/test-fixtures/image-node-subprocess/app.js Outdated
@@ -0,0 +1,12 @@
require("child_process").spawn("go", [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting testing approach 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went the "pure go" approach first with no success --I had a few iterations on it before I gave up and went this approach.

spiffcs
spiffcs approved these changes Oct 29, 2021
View reviewed changes
@wagoodman
remove extra line in makefile
ff06728 
Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman enabled auto-merge (squash) October 29, 2021 14:50
@wagoodman wagoodman merged commit afc9de6 into main Oct 29, 2021
@wagoodman wagoodman deleted the stdin-check branch October 29, 2021 14:52
@wagoodman wagoodman mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spiffcs spiffcs spiffcs approved these changes

+1 more reviewer

@luhring luhring luhring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wagoodman wagoodman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to invoke grype as an external process since 0.8.0

3 participants

@wagoodman @luhring @spiffcs