Migrate LocationSet and add Dart support #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Galvão Xavier <[email protected]>
Signed-off-by: Jonas Galvão Xavier <[email protected]>
Signed-off-by: Jonas Galvão Xavier <[email protected]>
jonasagx
commented
Apr 1, 2022
| definedPkgTypes.Add(p) | ||
| } | ||
| // exceptions: rust, php, and msrc (kb) are not under test | ||
| // exceptions: rust, php, dart and msrc (kb) are not under test |
There was a problem hiding this comment.
Q: how we decide what goes in this list of exceptions?
There was a problem hiding this comment.
good question. I think context matters is the short answer. MSRC is not officially supported, and rust/php does not have specific support other than the stock matcher. I think dart falls into the latter category as well. As we add more catalogers we should try to eventually follow up with equivalent matcher support in grype (out of scope for this PR).
Signed-off-by: Jonas Galvão Xavier <[email protected]>
wagoodman
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts grype to use LocationSet introduced in anchore/syft#930
Updates tests to support Dart packages.
Signed-off-by: Jonas Galvão Xavier [email protected]