Add unaffected package and CPE stores #2888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12e2d5e to
2a045fa
Compare
Signed-off-by: Alex Goodman <[email protected]>
3cc59ef to
26e0256
Compare
spiffcs
approved these changes
Sep 4, 2025
Contributor
spiffcs
left a comment
There was a problem hiding this comment.
No more notes/comments from our previous sync review. I went through each file and didn't see anything else I had questions on. Test coverage is A+ and all the cases seem covered correctly for new unaffected code paths.
👍 LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a deferred feature from the initial v6 schema work from janurary: the ability to describe packages and CPEs that are explicitly not affected by a vulnerability.
Specifically, this adds:
UnaffectedPackageStoreUnaffectedCPEStorenote: we cannot refactor the existing alpine naks (e.g.
<= 0version constraint) since there are older clients that depend on that mechanism (unless we decide to duplicate all of that data, which is an option if we wish).Related PR: anchore/grype-db#648