fix: normalize java runtime qualifiers in maven version comparisons #3034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Gardner <[email protected]>
Contributor
Author
|
When researching this a bit more, I found that the suffix is non-standard for Maven parsing. It supports I believe the fix is still appropriate, but let me know if I should be approaching this differently! |
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
approved these changes
Nov 14, 2025
Contributor
Author
|
Thank you for the review and help! |
spiffcs
added a commit
to joonas/grype
that referenced
this pull request
Nov 20, 2025
* main: chore(deps): update tools to latest versions (anchore#3051) chore(deps): bump actions/checkout from 5.0.0 to 5.0.1 (anchore#3059) chore(deps): bump anchore/sbom-action from 0.20.9 to 0.20.10 (anchore#3060) chore(deps): bump github/codeql-action from 4.31.2 to 4.31.4 (anchore#3061) chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 (anchore#3063) chore(deps): bump actions/setup-go in /.github/actions/bootstrap (anchore#3064) chore(deps): update anchore dependencies (anchore#3055) test: update quality gate db to latest version (anchore#3053) fix: normalize java runtime qualifiers in maven version comparisons (anchore#3034) chore(deps): update tools to latest versions (anchore#3045) fix: junit template use CDATA block to prevent XML parse errors (anchore#3019) feat: add basic VEX support for SBOM and other sources chore(deps): bump golang.org/x/tools from 0.38.0 to 0.39.0 (anchore#3046) chore(deps): bump github.com/opencontainers/selinux (anchore#3044) chore(deps): bump github.com/olekukonko/tablewriter from 1.1.0 to 1.1.1 (anchore#3039) keep nested loggers labeled (anchore#3040)
kbsteere
added a commit
to kbsteere/wolfictl
that referenced
this pull request
Dec 2, 2025
…chore/grype#3034 Signed-off-by: Kyle Steere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Normalize Java runtime qualifiers in Maven version comparisons
Problem
Maven/Java packages may include JRE/JDK runtime qualifiers in filenames (
.jreNN,.jdkNN), but these qualifiers may not appear in the JAR's internal version metadata (fromMANIFEST.MF).When Grype compares versions:
12.10.2(extracted from JAR metadata)12.10.2.jre11(from advisory database)12.10.2≠12.10.2.jre11→ False positive CVE reportedThe runtime qualifiers don't affect semantic versioning and should be normalized before comparison.
Solution
Strip
.jre<digits>and.jdk<digits>suffixes before Maven version parsing, following the existing pattern used for other version qualifiers (RELEASE, FINAL, GA).Behavior after fix:
12.10.2==12.10.2.jre11✅12.10.2.jre11==12.10.2.jdk17✅12.10.1<12.10.2.jre11✅ (actual version differences preserved)Testing
References
github.com/masahiro331/go-mvn-version(does not normalize runtime qualifiers)