Support gomod configuration in goreleaser #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is failing because the runner checks out the repo with Without fully knowing how you use |
|
@xtreme-conor-nosal using Additionally I rebased your branch from the latest on main and bumped to the version of goreleaser to the latest version as of today (the buildx change is from a deprecation warning I got from the latest update). |
wagoodman
approved these changes
Sep 14, 2021
Signed-off-by: Conor Nosal <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
spiffcs
added a commit
that referenced
this pull request
Oct 1, 2021
* main: Support gomod configuration in goreleaser (#391) Update description for Slack link (#439) Updates approach for epoch handling in rpm comparisons (#438) Feature: Specifying ignore rules for vulnerability matches (#430) Update Syft to v0.24.1 (#433) pull in grype-db default language namespace namer + fix imbalanced version v prefixes (#434) add stock matcher (language + cpe matching) (#432) Add SBOM to releases (#429) Add announcement for KubeCon meetup (#428) Improve log message for CPE parsing error (#426) Bugfixes + Integration test for sbom input vs grype library comparison (#424) Allow CPE parsing failures (#425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goreleaser added support for a
gomod.proxyconfiguration stanza in v0.162.0The docs indicate --snapshot will ignore the setting so the flag is replaced with the implied
--skip-publish --skip-validate --skip-announce.I looked into adding an explicit proxy config into .goreleaser.yaml, but it appears the goreleaser cli doesn't allow for dynamic overrides. --config is repeatable, but the second file replaces the config instead of merging.
make bootstrap buildshould behave the same, but these changes allow for:`
make bootstrap
echo "gomod:
proxy: true
env:
make build
`
Signed-off-by: Conor Nosal [email protected]