Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@harmw
Copy link
Contributor

@harmw harmw commented Apr 4, 2022

This should take care of #123 in that it will allow arbitrary source reading for grype. This way you can simple read SBOM files directly.

@kzantow
Copy link
Contributor

kzantow commented Apr 4, 2022

Thanks for this @harmw overall it looks good, thinking of the ergonomics, I wonder if it would be more consistent with image and path options to just call the parameter sbom?

@harmw
Copy link
Contributor Author

harmw commented Apr 4, 2022

yeah so I started with exactly that an mind, but figured there are some other options supported in grype that may be of interest and are configurable this way - happy to change it back into sbom though, as it's a little cleaner (though less versatile) :)

@kzantow
Copy link
Contributor

kzantow commented Apr 4, 2022

I think using sbom, and always having it prepend the sbom: prefix would be more consistent with the current state of this action. We made a conscious decision not to support everything in the action command parameters. There is always the option to add a .grype.yaml in the repository root for more advanced configuration, although the source parameter is tricky. Additionally, there are some other options like just using the download sub-action and invoking grype directly. But adding an sbom definitely sounds like a useful improvement to the action!

@harmw
Copy link
Contributor Author

harmw commented Apr 4, 2022

We made a conscious decision not to support everything in the action command parameters.

check, and happy to change it 👍

Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this! The timing of your PR is very fortuitous, as I just started revisiting this problem today and would love to get it solved. Would it be possible to join the Anchore community Slack for some more synchronous discussion on how best to proceed?

The two specific things I'm looking to get addressed are:

  • workflow between sbom-action and scan-action, which may be just documenting the aforementioned output-file and updating the documentation here
  • adding some sort of automated test (this is not always the easiest for projects like this that are essentially glue code between systems. but I'm sure we could figure out a way)

@harmw
Copy link
Contributor Author

harmw commented Apr 5, 2022

automated tests, yes please - tbh I found the current set of tests, or rather the layout of the project a little (too) complex 🙈 maybe something to pick up in a separate PR, but that also feels a little daunting.
And probably also due to my lack of javascript ecosystem knowledge 😂

Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @harmw !

@kzantow kzantow linked an issue Apr 6, 2022 that may be closed by this pull request
1 task
@kzantow kzantow merged commit d39ae4a into anchore:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate with sbom-action (and other) SBOM artifacts for scanning

2 participants