-
Notifications
You must be signed in to change notification settings - Fork 83
feat: read from arbitrary grype source #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this @harmw overall it looks good, thinking of the ergonomics, I wonder if it would be more consistent with |
|
yeah so I started with exactly that an mind, but figured there are some other options supported in grype that may be of interest and are configurable this way - happy to change it back into sbom though, as it's a little cleaner (though less versatile) :) |
|
I think using |
check, and happy to change it 👍 |
Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Harm Weites <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this! The timing of your PR is very fortuitous, as I just started revisiting this problem today and would love to get it solved. Would it be possible to join the Anchore community Slack for some more synchronous discussion on how best to proceed?
The two specific things I'm looking to get addressed are:
- workflow between
sbom-actionandscan-action, which may be just documenting the aforementionedoutput-fileand updating the documentation here - adding some sort of automated test (this is not always the easiest for projects like this that are essentially glue code between systems. but I'm sure we could figure out a way)
|
automated tests, yes please - tbh I found the current set of tests, or rather the layout of the project a little (too) complex 🙈 maybe something to pick up in a separate PR, but that also feels a little daunting. |
Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Keith Zantow <[email protected]> Signed-off-by: Harm Weites <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
Signed-off-by: Keith Zantow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this @harmw !
This should take care of #123 in that it will allow arbitrary source reading for grype. This way you can simple read SBOM files directly.