Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@erhan-
Copy link
Contributor

@erhan- erhan- commented Nov 17, 2022

Adds the current process environment variables to the grype process. Useful for proxy variables.

Might fix #197

@erhan- erhan- changed the title Include process environment into grype execution Draft: Include process environment into grype execution Nov 17, 2022
@erhan-
Copy link
Contributor Author

erhan- commented Nov 17, 2022

I tried it on my repository. I think it picks the right action up but the result is the same. Have to dig a bit more I guess:

image

@kzantow
Copy link
Contributor

kzantow commented Nov 17, 2022

@erhan- you would need to run with @patch-1 as the version. (e.g. erhan-/scan-action@patch-1)

@kzantow
Copy link
Contributor

kzantow commented Nov 17, 2022

@erhan- I had a slightly different thing in mind (the same idea, just not modifying the process.env) -- I've also added a test, would you mind if I push these changes here?

@erhan- erhan- changed the title Draft: Include process environment into grype execution Include process environment into grype execution Nov 17, 2022
@erhan-
Copy link
Contributor Author

erhan- commented Nov 17, 2022

Please push and change however you think is best. It works now.

@kzantow
Copy link
Contributor

kzantow commented Nov 17, 2022

Also: it looks like you'll need to sign-off the commits, would you be able to do this?

@kzantow
Copy link
Contributor

kzantow commented Nov 17, 2022

Also: I'm looking in to these test failures, I'm pretty sure they are unrelated to this change...

@kzantow
Copy link
Contributor

kzantow commented Nov 17, 2022

@erhan- could you verify the current state of this PR is still working for you? If so, I can probably get this rebased, merged, and released for you.

(Also it would be good to know if HTTPS_PROXY works vs. the lowercase https_proxy)

@kzantow kzantow closed this Nov 17, 2022
@kzantow kzantow reopened this Nov 17, 2022
@erhan-
Copy link
Contributor Author

erhan- commented Nov 17, 2022

Sorry, I never added a sign-off commit before. I hereby also confirm that the code si for your project and I dont claim any rights.

I cant that test unfortunately if upper and lowercase work at the moment but I think I read something that we should use the lowercase one. It works and is the first time I got any results. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to check for vulnerability database update

2 participants