add action input for --add-cpes-if-none flag #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the user to be in control whether this flag is set or not. The previous behavior was not to add the flag, thus the default value here was set to 'false' in order to keep the current behavior. Signed-off-by: Sebastian Hoß <[email protected]>
Similar to the only-fixed action input, we simply read the user provided value or fallback to the default and the --add-cpes-if-none flag to the arguments of grype in case the action input is set to 'true'. Signed-off-by: Sebastian Hoß <[email protected]>
In order to use the new flag & test it, we need to rebuild the dist bundle. Signed-off-by: Sebastian Hoß <[email protected]>
Signed-off-by: Sebastian Hoß <[email protected]>
Signed-off-by: Sebastian Hoß <[email protected]>
Signed-off-by: Sebastian Hoß <[email protected]>
kzantow
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215 by adding another action input that toggles whether the
--add-cpes-if-noneflag is added to the grype command arguments.There are some local test failures but these seems to be caused by a missing OCI registry on localhost:5000 which I did not have. I've tested this change just now in metio/devcontainers@bbb47b0 and can see the correct results in an action run, e.g. at https://github.com/metio/devcontainers/actions/runs/4445318515/jobs/7804325686 (job name is "Scan Image with Grype")