Add changelog generation #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
alfredodeza
reviewed
Aug 26, 2020
| changelog: | ||
| mkdir -p $(DISTDIR) | ||
| @docker run -it --rm \ | ||
| -v "$(shell pwd)":/usr/local/src/your-app ferrarimarco/github-changelog-generator \ |
There was a problem hiding this comment.
yup, that's specific to the container they have built, not something we control. The CHANGELOG.md will get output to there, so instead of extracting from the container I just mount a volume to get it. Using their image still seemed relatively cleaner than pulling in a bunch of ruby dependencies and doing it ourselves.
luhring
approved these changes
Aug 27, 2020
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new make target
make changelogto generate a changelog in the root of the repo. Additionally adds this changelog to the GitHub Releases page on release in the form of a draft.Closes #159