adds the yarn.lock cataloger #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 28, 2020 15:18
Signed-off-by: Alfredo Deza <[email protected]>
Signed-off-by: Alfredo Deza <[email protected]>
Signed-off-by: Alfredo Deza <[email protected]>
Signed-off-by: Alfredo Deza <[email protected]>
Signed-off-by: Alfredo Deza <[email protected]>
Signed-off-by: Alfredo Deza <[email protected]>
wagoodman
reviewed
Jul 29, 2020
| "github.com/anchore/syft/syft/pkg" | ||
| ) | ||
|
|
||
| var composedNameExp = regexp.MustCompile("^\"(@{1}[^@]+)") |
There was a problem hiding this comment.
nit, non-blocking: There might be a simplification here... I think you may be able to get the composed & single into a single regex, matching on the first capture group: "^\"(@{0,1}[^@]+)" (not 100% certain though)
There was a problem hiding this comment.
I tried fiddling around with the regex to match both (and I tried again with your suggestion) but couldn't get it to work for both. We can always come back to this one and improve it if we have a nicer regex to work with
wagoodman
approved these changes
Jul 29, 2020
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
adds the yarn.lock cataloger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parses
yarn.lockfiles while dedupping (per file only).Closes #8