Export UI handlers for reuse in other tools #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredodeza
approved these changes
Jul 30, 2020
|
I'll open up a PR shortly that shows it in action, but essentially it's moving the packages releated to handling specific UI events to a single "Handler" object https://github.com/anchore/syft/pull/113/files#diff-12d657a64bc373ae734f4f3614eb6414 which can be used in grype. |
|
FYI, I bumped jotframe to pull the fix for the behavior that @rossturk was seeing earlier (cursor race conditions at frame close before showing the report, which leads to sometimes overwriting the last status line with the report) |
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
* export UI handlers for reuse in other tools * bump jotframe to fix cursor issues at frame close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other toolbox tools to selectively re-use UI elements and incorporate in other ETUIs in the form of a single Handler object. Grype will be using these to display common elements.