Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove incorrect bouncer license allow #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2022
Merged

remove incorrect bouncer license allow #1138

merged 3 commits into from
Aug 3, 2022

Conversation

@spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Aug 3, 2022

Signed-off-by: Christopher Phillips [email protected]

@spiffcs
remove blanket allow
32093a2 
Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs changed the title remove blanket allow remove bouncer license allow Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    14.8ms ± 7%    11.7ms ± 0%  -21.27%  (p=0.008 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.70ms ± 2%    1.31ms ± 6%  -22.88%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            4.23ms ± 1%    3.32ms ± 0%  -21.65%  (p=0.016 n=5+4)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.37ms ± 1%    1.05ms ± 0%  -23.57%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         965µs ± 1%     731µs ± 1%  -24.24%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                    1.17ms ± 2%    0.85ms ± 0%  -27.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.64ms ± 1%    1.24ms ± 1%  -23.97%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      18.4ms ± 1%    15.0ms ± 1%  -18.63%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.58ms ± 3%    1.25ms ± 0%  -21.20%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          3.00µs ± 3%    2.20µs ± 1%  -26.85%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.76ms ± 2%    1.39ms ± 0%  -21.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    914µs ± 1%     672µs ± 0%  -26.47%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.222 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             944kB ± 0%     944kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.595 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      301kB ± 0%     301kB ± 0%   +0.21%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.151 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%   -0.08%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=1.000 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.079 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%     ~     (p=0.667 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.54k ± 0%     5.53k ± 0%     ~     (p=0.333 n=4+5)
ImagePackageCatalogers/javascript-package-cataloger-2         3.31k ± 0%     3.31k ± 0%     ~     (p=0.556 n=4+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.10k ± 0%     8.10k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.341 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (p=0.968 n=5+4)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (all equal)

@spiffcs
Copy link
Contributor Author

spiffcs commented Aug 3, 2022

Nice this is failing because it's now checking the licenses correctly so we can resolve those issues on this PR as well.

@spiffcs spiffcs changed the title remove bouncer license allow remove incorrect bouncer license allow Aug 3, 2022
@kzantow kzantow merged commit 042304e into main Aug 3, 2022
@kzantow kzantow deleted the remove-allow-list-syft branch August 3, 2022 13:46
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
@spiffcs @aiwantaozi
Correct squashfs import and fix incorrect bouncer configuration (anch…
d208e3b 
…ore#1138)
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs
Correct squashfs import and fix incorrect bouncer configuration (anch…
12d46ac 
…ore#1138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

@westonsteimel westonsteimel westonsteimel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spiffcs @wagoodman @westonsteimel @kzantow