Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "External sources configuration (#1158)" #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

Revert "External sources configuration (#1158)" #1191

merged 1 commit into from
Sep 1, 2022

Conversation

@spiffcs
Copy link
Contributor

@spiffcs spiffcs commented Sep 1, 2022 •
edited
Loading

This reverts commit 1329688

This commit should instead be merged into the kubecon development branch if it hasn't already

@spiffcs
Revert "External sources configuration (#1158)"
4011cc5 
This reverts commit 1329688.

Signed-off-by: Christopher Phillips <[email protected]>
@spiffcs spiffcs force-pushed the revert-external-sources branch from 1808beb to 4011cc5 Compare September 1, 2022 19:15
@spiffcs spiffcs requested a review from wagoodman September 1, 2022 19:15
@github-actions
Copy link

github-actions bot commented Sep 1, 2022 •
edited
Loading

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/alpmdb-cataloger-2                    11.7ms ± 1%    12.0ms ±23%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.32ms ± 1%    1.26ms ± 0%   -4.92%  (p=0.016 n=4+5)
ImagePackageCatalogers/python-package-cataloger-2            3.34ms ± 0%    3.20ms ± 0%   -4.00%  (p=0.008 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.08ms ± 0%    1.02ms ± 0%   -5.90%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         749µs ± 1%     709µs ± 1%   -5.36%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     897µs ± 1%     828µs ± 0%   -7.69%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                     1.29ms ± 0%    1.19ms ± 1%   -8.17%  (p=0.008 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.7ms ± 1%    14.0ms ± 1%   -5.09%  (p=0.008 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.28ms ± 1%    1.15ms ± 1%  -10.79%  (p=0.008 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.25µs ± 1%    2.07µs ± 2%   -7.88%  (p=0.008 n=5+5)
ImagePackageCatalogers/dotnet-deps-cataloger-2               1.39ms ± 0%    1.30ms ± 2%   -5.89%  (p=0.008 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    713µs ± 0%     661µs ± 1%   -7.35%  (p=0.008 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/alpmdb-cataloger-2                    5.26MB ± 0%    5.26MB ± 0%     ~     (p=0.548 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               202kB ± 0%     202kB ± 0%     ~     (p=0.690 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             944kB ± 0%     944kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     214kB ± 0%     214kB ± 0%     ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         158kB ± 0%     158kB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     203kB ± 0%     203kB ± 0%     ~     (p=0.095 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      302kB ± 0%     302kB ± 0%     ~     (p=0.381 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.44MB ± 0%    3.44MB ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.25MB ± 0%    1.25MB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            672B ± 0%      672B ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                369kB ± 0%     369kB ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/portage-cataloger-2                    136kB ± 0%     136kB ± 0%     ~     (p=1.000 n=5+5)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/alpmdb-cataloger-2                     85.7k ± 0%     85.7k ± 0%     ~     (p=0.429 n=5+5)
ImagePackageCatalogers/ruby-gemspec-cataloger-2               4.25k ± 0%     4.25k ± 0%     ~     (p=1.000 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             16.6k ± 0%     16.6k ± 0%     ~     (p=0.841 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     5.53k ± 0%     5.53k ± 0%     ~     (p=1.000 n=5+4)
ImagePackageCatalogers/javascript-package-cataloger-2         3.32k ± 0%     3.32k ± 0%     ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     4.60k ± 0%     4.60k ± 0%     ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      8.13k ± 0%     8.13k ± 0%     ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       57.5k ± 0%     57.5k ± 0%     ~     (p=0.738 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      5.43k ± 0%     5.43k ± 0%     ~     (p=0.333 n=5+4)
ImagePackageCatalogers/go-module-binary-cataloger-2            15.0 ± 0%      15.0 ± 0%     ~     (all equal)
ImagePackageCatalogers/dotnet-deps-cataloger-2                7.27k ± 0%     7.27k ± 0%     ~     (all equal)
ImagePackageCatalogers/portage-cataloger-2                    3.59k ± 0%     3.59k ± 0%     ~     (all equal)

@spiffcs spiffcs marked this pull request as ready for review September 1, 2022 19:34
@spiffcs spiffcs merged commit 586d3fe into main Sep 1, 2022
@spiffcs spiffcs deleted the revert-external-sources branch September 1, 2022 19:45
spiffcs added a commit that referenced this pull request Sep 19, 2022
@spiffcs
Revert "External sources configuration (#1158)" (#1191)
c2ef3a9 
reverted as functionality is to be merged with dev branch of kubecon draft

Signed-off-by: Christopher Phillips <[email protected]>
aiwantaozi pushed a commit to aiwantaozi/syft that referenced this pull request Oct 20, 2022
@spiffcs @aiwantaozi
Revert "External sources configuration (anchore#1158)" (anchore#1191)
7362d59 
reverted as functionality is to be merged with dev branch of kubecon draft
spiffcs added a commit that referenced this pull request Oct 21, 2022
@spiffcs
Revert "External sources configuration (#1158)" (#1191)
a8ff83c 
reverted as functionality is to be merged with dev branch of kubecon draft

Signed-off-by: Christopher Phillips <[email protected]>
spiffcs added a commit that referenced this pull request Oct 21, 2022
@spiffcs
Revert "External sources configuration (#1158)" (#1191)
95f220c 
reverted as functionality is to be merged with dev branch of kubecon draft

Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@spiffcs
Revert "External sources configuration (anchore#1158)" (anchore#1191)
ea506dd 
reverted as functionality is to be merged with dev branch of kubecon draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spiffcs @wagoodman