Warn on errors from RPM DB parsing #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
kzantow
approved these changes
Sep 9, 2022
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
westonsteimel
approved these changes
Sep 9, 2022
spiffcs
added a commit
to luhring/syft
that referenced
this pull request
Sep 19, 2022
* main: bug: remove chance for panic; provide default attestation path (anchore#1214) refactor: update Makefile organization; update DEVELOPING.md instructions (anchore#1212) refactor: replace ioutil=>io; update linter (anchore#1211) Update bootstrap tools to latest versions. (anchore#1204) Add gosimports (anchore#1205) refactor: move formats from internal into syft module (anchore#1172) warn on errors from RPM DB parsing (anchore#1200) docs: improve Singularity image source docs (anchore#1190) Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
pushed a commit
that referenced
this pull request
Sep 19, 2022
Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Christopher Phillips <[email protected]>
This was referenced Sep 26, 2022
aiwantaozi
pushed a commit
to aiwantaozi/syft
that referenced
this pull request
Oct 20, 2022
Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Alex Goodman <[email protected]>
spiffcs
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if there are any issues when parsing an RPM DB entry the cataloging process halts. This is not consistent with other catalogers which instead log warnings when there are parsing errors and cataloging continues. This PR removes the error paths during execution and adds warnings instead.