Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Nov 16, 2020

  • Adds a helper function to lib.go for parsing the json output document to generate native syft objects (CatalogFromJSON) + adds an integration test to cover creating json and interpreting the same json to ensure a comparison continues to work.
  • Renames Scope to Source + renames the scope package to source
  • Moves all implementations in the resolvers package to the source package
  • Migrates all source metadata to a new source.Metadata struct and removes the generation of this metadata from the JSON presenter
  • Adds more documentation commenting (seemingly randomly... but progress is progress)

@wagoodman wagoodman marked this pull request as ready for review November 17, 2020 14:04
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is big step forward! 🎉 Just a few comments for review

Component: Component{
Type: "container",
Name: srcMetadata.ImageMetadata.UserInput,
Version: srcMetadata.ImageMetadata.Digest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a request for change, but the thought just occurred to me — is it worth checking any other CycloneDX tools to see how they handle this exact case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wagoodman wagoodman merged commit 7193955 into main Nov 17, 2020
@wagoodman wagoodman deleted the document-import branch November 17, 2020 18:21
@wagoodman wagoodman added the enhancement New feature or request label Nov 17, 2020
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants