Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add the ability to run syft from a scratch image. #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 16, 2020
Merged

Add the ability to run syft from a scratch image. #288

merged 5 commits into from
Dec 16, 2020

Conversation

@Toure
Copy link
Contributor

@Toure Toure commented Dec 9, 2020

This change will allow endusers or CI to run syft from a
minimum image which will simplify CI deployment.

closes: #228
Signed-off-by: Toure Dunnon [email protected]

luhring
luhring reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'd also suggest that adding documentation for how to use this Docker image is a "must have" for this addition, since it may not be obvious how to use it (e.g. that most workflows would require access to the Docker daemon).

@wagoodman
Copy link
Contributor

ditto on @luhring s comment for documentation, just a small example or two in the readme will go a long way.

@Toure Toure force-pushed the syft_docker_image branch from 4af6362 to b7e5d59 Compare December 14, 2020 13:04
Toure Dunnon added 2 commits December 14, 2020 08:10
Add the ability to run syft from a scratch image.
07f2c2f 
This change will allow endusers or CI to run syft from a
minimum image which will simplify CI deployment.

Signed-off-by: Toure Dunnon <[email protected]>
added: update to README.md to indicate on how to use the new feature.
c626cb1 
Signed-off-by: Toure Dunnon <[email protected]>
@Toure Toure force-pushed the syft_docker_image branch from b7e5d59 to c626cb1 Compare December 14, 2020 13:11
wagoodman
wagoodman reviewed Dec 14, 2020
View reviewed changes
wagoodman
wagoodman reviewed Dec 14, 2020
View reviewed changes
wagoodman
wagoodman reviewed Dec 14, 2020
View reviewed changes
wagoodman
wagoodman reviewed Dec 14, 2020
View reviewed changes
wagoodman
wagoodman approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Toure Toure merged commit 688aa2e into main Dec 16, 2020
@Toure Toure deleted the syft_docker_image branch December 16, 2020 15:39
@wagoodman wagoodman mentioned this pull request Dec 16, 2020
Merged
@user287435 user287435 mentioned this pull request Feb 7, 2023
Open
@stnert stnert mentioned this pull request Mar 1, 2023
Open
@ddzzj ddzzj mentioned this pull request Oct 19, 2023
Open
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Merge pull request anchore#288 from anchore/syft_docker_image
fc2e150 
Add the ability to run syft from a scratch image.
@peichels peichels mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagoodman wagoodman wagoodman approved these changes

@alfredodeza alfredodeza Awaiting requested review from alfredodeza

+1 more reviewer

@luhring luhring luhring left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker image

5 participants

@Toure @wagoodman @alfredodeza @luhring