Allow for multiple pom.properties delimiters #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
…rties Signed-off-by: Alex Goodman <[email protected]>
luhring
approved these changes
Mar 20, 2021
|
This seems related to #330 that explains that strictness in parsing causes several omissions. I'd propose raising the priority of that ticket so that we can enable permissive parsing for all parsers |
This was referenced Mar 29, 2021
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…arse-delimiter Allow for multiple pom.properties delimiters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the parsing of pom.properties to allow for both
=and:delimiters.Additionally this PR loosens the error handling on the java parsing execution path to show warnings for individual parsing errors instead of bubbling up small parsing errors back up to the main catalog function. This allows for java packages unrelated to the parser problems to still be cataloged.
Closes #349